search

microsoft / garnet

Garnet is a remote cache-store from Microsoft Research that offers strong performance (throughput and latency), scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet can work with existing Redis clients.
https://microsoft.github.io/garnet/
MIT License
10.37k stars 525 forks source link

Fix Bugs, Caused by Hello Respones Types #811 #818

Closed yuseok-kim-edushare closed 49 minutes ago

yuseok-kim-edushare commented 1 day ago

This PR will Fix Hello Responss's Type To resolve #811

What is changed?

RESP hello command processing logic updated to be same response as Redis's

https://github.com/redis/redis/blob/unstable/src/commands/hello.json

Thanks to @mp911de He provide what is matter need to fix

And Also Thanks to @badrishc He Support to me and provide tip to get trace log from garnet server

yuseok-kim-edushare commented 1 day ago

@microsoft-github-policy-service agree

badrishc commented 1 day ago

Excellent detective work! Really glad to see this get fixed :).

yuseok-kim-edushare commented 7 hours ago

Maybe, It's too much worrying, but I'll try to rebase to my PR when main branch update