search

microsoft / gather

Spit shine for Jupyter notebooks 🧽✨
https://microsoft.github.io/gather
MIT License
532 stars 38 forks source link

Bugfix: find name uses within classes #28

Closed joyceerhl closed 5 years ago

joyceerhl commented 5 years ago

For #23

With this PR, the fixed notebook looks like this: bugfix

@andrewhead feedback is much appreciated! :-) And thank you for your patience and help so far!

joyceerhl commented 5 years ago

Can you add a unit test for getUses to verify the fix on a minimal class?

https://github.com/microsoft/gather/pull/28/files#diff-570ebd4142e7b14c265ba52bd048c158R379-R404

Can you also run a test to verify that params used in an instance function body aren't registered as "uses" of that param?

I might have misunderstood your request--is this what you had in mind? https://github.com/microsoft/gather/pull/28/files#diff-570ebd4142e7b14c265ba52bd048c158R419-R426

Also, if you haven't already, can you verify the regression tests run fine (jlpm run test), and prettify the source (jlpm run format:all)?

Done and done--thanks for the reminder!