Move gather button to tab on top of cell

microsoft / gather

Spit shine for Jupyter notebooks 🧽✨

https://microsoft.github.io/gather

MIT License

533 stars 38 forks source link

Move gather button to tab on top of cell #29

Closed andrewhead closed 5 years ago

andrewhead commented 5 years ago

Continuation of https://github.com/microsoft/gather/pull/17

andrewhead commented 5 years ago

@jasonsjiang Can you take a look at the code, see if there's anything fishy, and test out these changes on your machine? When you're ready, I think I'm ready to merge into master ^_^

jasonsjiang commented 5 years ago

I ran through a notebook with both text and data frame outputs and the button works on output types and fixed some issues with the button (see #30).

The button also floats above the output cell and I believe the offsetHeight rounds to the next whole number. I did some inspection and the button height was 27.5px but top was set at -28px. Not sure if adding a constant to buttonHeight is an appropriate workaround.