microsoft / gather

Spit shine for Jupyter notebooks 🧽✨
https://microsoft.github.io/gather
MIT License
532 stars 38 forks source link

Bugfix: correct getTextSlice slicing logic #32

Closed joyceerhl closed 5 years ago

joyceerhl commented 5 years ago

For #31

With this fix, CellSlice.textSliceLines does not include duplicate lines of code after the end of a funcdef or classdef. Depending on whether it's semantically accurate to modify the location object that is returned by the parser, we might want to fix this issue at the parser level instead? @andrewhead