search

microsoft / gather

Spit shine for Jupyter notebooks 🧽✨
https://microsoft.github.io/gather
MIT License
532 stars 38 forks source link

Icons for gathering not appearing in version browser #34

Closed andrewhead closed 4 years ago

andrewhead commented 5 years ago

Describe the bug

The icons for "Open in notebook" and "Copy to clipboard" in the version browser are not appearing.

image

To Reproduce

Click on a variable or output, then click on "Gather to... Version Browser". You should be able to see that the icons are missing on the gather buttons.

Expected behavior

The icons should appear on the buttons, like so (screenshot taken from the version of gather currently hosted on BinderHub):

image

Additional context

This problem was probably introduced when gather started using Jupyter Lab libraries version >1.0 and the paths to the Jupyter icons changed. I already fixed the paths for the icons for the buttons in the Jupyter notebook toolbar in this commit, so we probably just need to point the CSS classes of the buttons in the version browser interface to the classes defined in that commit.

rdrahul commented 5 years ago

Can i take this up?

andrewhead commented 5 years ago

Hi @rdrahul thanks for pinging ^_^ Yeah, please do! I'm happy to review a PR if you want to put something together.

andrewhead commented 4 years ago

Solved by @rdrahul in https://github.com/microsoft/gather/pull/36 🎉