microsoft / genaiscript

Generative AI Scripting
https://microsoft.github.io/genaiscript/
MIT License
81 stars 22 forks source link

promptfoo 0.62 #517

Closed pelikhan closed 4 weeks ago

pelikhan commented 4 weeks ago

CLI Changes

Library Changes

generated by genaiscript pr-describe

github-actions[bot] commented 4 weeks ago

Concerns:

  1. 🚨 The value property in the PromptScriptTestResult interface has been changed to an object with an evalId property. This change assumes that all responses will have an evalId, which may not be the case for all test results. It could lead to runtime errors if the evalId is not provided in the response.

  2. 🚨 In the startTestViewer function, the openUrlInTab function call is commented out. This means that the test viewer URL will not automatically open in a new tab, which could be a regression in user experience.

  3. 🧐 The startTestViewer function now returns serverUrl, but the function's return type is not specified. It's a good practice to explicitly define the return type for clarity and maintainability.

  4. 🧐 The npx command in the startTestViewer function includes a --yes flag that was not present before. This change should be reviewed to ensure it aligns with the intended behavior and security practices, as it could automatically agree to prompts without user confirmation.

Suggested code fixes:

generated by genaiscript pr-review