Closed pelikhan closed 4 weeks ago
Concerns:
🚨 The value
property in the PromptScriptTestResult
interface has been changed to an object with an evalId
property. This change assumes that all responses will have an evalId
, which may not be the case for all test results. It could lead to runtime errors if the evalId
is not provided in the response.
🚨 In the startTestViewer
function, the openUrlInTab
function call is commented out. This means that the test viewer URL will not automatically open in a new tab, which could be a regression in user experience.
🧐 The startTestViewer
function now returns serverUrl
, but the function's return type is not specified. It's a good practice to explicitly define the return type for clarity and maintainability.
🧐 The npx
command in the startTestViewer
function includes a --yes
flag that was not present before. This change should be reviewed to ensure it aligns with the intended behavior and security practices, as it could automatically agree to prompts without user confirmation.
Suggested code fixes:
value
property in PromptScriptTestResult
can handle cases where evalId
might not be present.openUrlInTab
function to maintain the previous functionality.startTestViewer
function.--yes
flag in the npx
command to ensure it's necessary and secure.generated by genaiscript pr-review
CLI Changes
promptfoo
version in the CLI commands documentation from^0.61.0
to^0.62.0
.Library Changes
promptfoo
dependency version from^0.61.0
to^0.62.0
inpackage.json
.openai
dependency version from^4.48.1
to^4.48.3
in bothcli
andcore
package.json
files.PromptScriptTestResult
interface inmessages.ts
to include anevalId
string in thevalue
property.EMOJI_FAIL
andEMOJI_SUCCESS
constants intestcontroller.ts
.activateTestController
function intestcontroller.ts
to use the newserverUrl
and append output with emojis and error messages.startTestViewer
function intestcontroller.ts
to returnserverUrl
and updated the terminal command to include--yes
flag.