microsoft / genaiscript

Generative AI Scripting
https://microsoft.github.io/genaiscript/
MIT License
81 stars 22 forks source link

configurable default model #544

Closed pelikhan closed 2 weeks ago

pelikhan commented 2 weeks ago

Environment variable to specify the default model for all scripts

generated by pr-describe

pelikhan commented 2 weeks ago

/genai-describe

pelikhan commented 2 weeks ago

/genai-review

github-actions[bot] commented 2 weeks ago

However, there are a couple of areas which could be improved:

  1. In the cli.ts file, the async keyword is added to the preAction hook. However, it's unclear if the parent function that calls this hook can handle promises or async operations. If the parent function can't handle promises, this could lead to unhandled promise rejections.

  2. In the constants.ts file, the GITHUB_PULLREQUEST_REVIEW_COMMENT_LINE_DISTANCE constant is added but it's not clear how this constant is used. If this is an important configuration value, it might be better to put it into a configuration file or in environment variables.

Otherwise, LGTM :rocket:.

generated by pr-review