microsoft / generator-docker

Yeoman generator for Docker
Other
346 stars 69 forks source link

Bug - When using a - with Yo Docker as part of the project/composed app, Build/Debugging doesn't work #106

Open CESARDELATORRE opened 8 years ago

CESARDELATORRE commented 8 years ago

I made quite a few tests and conclude saying that When using a "-" with Yo Docker as part of the project/composed app, Build/Debugging doesn't work.

THIS DOESN’T WORK: $imageName="cesardl/netcorewebapimicroservice25" $projectName="docker-composed-app"  BUG $serviceName="netcorewebapimicroservice25"

THIS WORKS: $imageName="cesardl/netcore-webapi-microservice2" $projectName="dockercomposedapp" $serviceName="netcore-webapi-microservice2"

I think that the issue/bug with “-” happens only for the projectName (which is the ComposedAppName)

Thanks, Cesar.

Sample error: Starting: "C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe" .\dockerTask.ps1 -StartDebugging Running on http://docker:5000 StartDebugging : Could not find a container named docker-composed-app_netcorewebapimicroservice25_1 At C:\Dev\BugCaseComposedApp\netcorewebapimicroservice25\dockerTask.ps1:156 char:5

NCarlsonMSFT commented 8 years ago

This should now be fixed in master. The underlying issue is that docker-compose ignores -s in the project name for docker-compose. We have updated the generator to like-wise ignore -s (and other unsupported characters) in the project name for docker compose.