search

microsoft / ghcrawler

Crawl GitHub APIs and store the discovered orgs, repos, commits, ...
MIT License
373 stars 90 forks source link

Preserve case by default in storage doc store #141

Closed geneh closed 6 years ago

geneh commented 6 years ago

Related to https://github.com/clearlydefined/crawler/issues/123

jeffmcaffer commented 6 years ago

Looks good. The only question I have is about the default being true. That means that when this code is eventually merged back into master, we will have to remember to set it to false.

Also don't see how one would change the setting. Perhaps just use this.options.preserveCase rather than passing a value in.

You could default that to false in the code and then set it to true in the ClearlyDefined crawler.