search

microsoft / ghcrawler

Crawl GitHub APIs and store the discovered orgs, repos, commits, ...
MIT License
373 stars 90 forks source link

Add rootRequest in metadata #172

Closed geneh closed 4 years ago

geneh commented 4 years ago

Add rootRequest in metadata to enable SLA tracking.

kivancmuslu commented 4 years ago

One more question: what gets into rootRequest when the there is none (e.g., it is initiated by a maintenance job or through the dashboard)? I would assume empty or null for now, but just checking.

kivancmuslu commented 4 years ago

Yet a final (I hope) question: rootRequest will end up getting the urn of the event, right?

geneh commented 4 years ago

Yet a final (I hope) question: rootRequest will end up getting the urn of the event, right?

That turned out to be a bit complicated given the current architecture. It'll be something like event_trigger@/orgs/ContosoDev/events/7e5556b0-e0c2-11e9-989a-cfaf691dcf05. The good news is that the rootUrn in events table is going to be exactly the same, so all the changes can be tracked easily without any string manipulations. Does it make sense?

kivancmuslu commented 4 years ago

Yet a final (I hope) question: rootRequest will end up getting the urn of the event, right?

That turned out to be a bit complicated given the current architecture. It'll be something like event_trigger@/orgs/ContosoDev/events/7e5556b0-e0c2-11e9-989a-cfaf691dcf05. The good news is that the rootUrn in events table is going to be exactly the same, so all the changes ca be tracked easily without any string manipulations. Does it make sense?

Haha, yeah, this is great! I was already doing all the string manipulations (realized the format after looking at the examples) and I was about to ask you whether we can simplify it. Did not realize that this new column is being added to the events table as well. Makes perfect sense.