search

microsoft / git

A fork of Git containing Microsoft-specific patches.
http://git-scm.com/
Other
782 stars 92 forks source link

Merge upstream fix for osx-gcc job #650

Closed derrickstolee closed 5 months ago

derrickstolee commented 5 months ago

I noticed the osx-gcc job failing in #647 so I found this upstream fix from @peff. Merging now to unblock PR builds in microsoft/git.

jeffhostetler commented 5 months ago

Do we still use or need the osx-gcc job? I thought we fixed the clang job to make universal binaries, but I may be thinking of something else.

derrickstolee commented 5 months ago

Do we still use or need the osx-gcc job? I thought we fixed the clang job to make universal binaries, but I may be thinking of something else.

It's still used upstream, so it would be a deviation from upstream to delete it (and that might cause merge conflicts during future rebases).