search

microsoft / github-actions-for-desktop-apps

This repo contains a sample WPF application to demonstrate how to create CI/CD pipelines using GitHub Actions.
MIT License
353 stars 108 forks source link

Unnecessary PropertyGroups for PlatformTarget? #21

Closed AArnott closed 4 years ago

AArnott commented 4 years ago

Are all these really necessary?

https://github.com/microsoft/github-actions-for-desktop-apps/blob/d0fbf5cbc39057dea30244fb7ef6c5ae9c3b1ab8/MyWPFApp/MyWPFApp.csproj#L13-L35

It seems if defining these is necessary can't it be done in one step?

<PlatformTarget>$(Platform)</PlatformTarget>

But I'd be surprised if that behavior isn't the default.

edwardskrod commented 4 years ago

Fixed by https://github.com/microsoft/github-actions-for-desktop-apps/pull/22