search

microsoft / github-actions-for-desktop-apps

This repo contains a sample WPF application to demonstrate how to create CI/CD pipelines using GitHub Actions.
MIT License
353 stars 108 forks source link

Update the PlatformTarget and CI trigger. #22

Closed edwardskrod closed 4 years ago

edwardskrod commented 4 years ago
AArnott commented 4 years ago

This failure appears to be because the Action ran on push of your source branch (and your branch doesn't include the fix recently pushed to master).

Should you adjust your github workflow to trigger on PR, and keep the push trigger reserved to just the master branch? That way, the action would run on the merged result and it would have passed on this PR, even with the stale source branch.

edwardskrod commented 4 years ago

This failure appears to be because the Action ran on push of your source branch (and your branch doesn't include the fix recently pushed to master).

Should you adjust your github workflow to trigger on PR, and keep the push trigger reserved to just the master branch? That way, the action would run on the merged result and it would have passed on this PR, even with the stale source branch.

That's a good idea. Thanks :)

LanceMcCarthy commented 4 years ago

That's how I've setup mine, and it's kept the noise down significantly https://github.com/LanceMcCarthy/MediaFileManager/blob/2559153c481d33c2fee584fce508913646878dc6/.github/workflows/ci.yml#L9-L15

edwardskrod commented 4 years ago

That's how I've setup mine, and it's kept the noise down significantly https://github.com/LanceMcCarthy/MediaFileManager/blob/2559153c481d33c2fee584fce508913646878dc6/.github/workflows/ci.yml#L9-L15

Thanks @LanceMcCarthy