search

microsoft / github-actions-for-desktop-apps

This repo contains a sample WPF application to demonstrate how to create CI/CD pipelines using GitHub Actions.
MIT License
352 stars 109 forks source link

[Question] Uap 19041 Support #29

Closed LanceMcCarthy closed 4 years ago

LanceMcCarthy commented 4 years ago

Hi Team,

I just updated my app's packaging project to use the 2004 SDK, but it looks like Actions isn't ready for it?

image

If you want to see the build output, it's here (disregard the warnings, scroll to the bottom) https://github.com/LanceMcCarthy/MediaFileManager/actions/runs/113382459

If you want to see the initiating PR, it's here https://github.com/LanceMcCarthy/MediaFileManager/pull/17

edwardskrod commented 4 years ago

The same thing happened to me when I targeted 10.0.19041.0: https://github.com/microsoft/github-actions-for-desktop-apps/pull/30/checks?check_run_id=709249059

@chrispat Are the builds failing because the build machines don't have Windows 10 SDK, version 2004 on them? https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/

chrispat commented 4 years ago

Could be the the latest VS has not rolled out yet https://github.com/actions/virtual-environments/issues/932#issuecomment-632985706.

LanceMcCarthy commented 4 years ago

Yep, that's definitely the reason, however I'm not sure just updating to VS 16.6 is going to solve it, they'll also need the 19041 SDK. I'll leave a note in that thread to ask them to remember to include the SDK.

edwardskrod commented 4 years ago

I believe VS will make 19041 the 'out of the box' sdk here pretty soon

LanceMcCarthy commented 4 years ago

It looks like they updated the VMs. However, I'm now getting a new problem:

" C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.Common.targets(136,115): error MSB4057: The target "ComputeFilesCopiedToPublishDir" does not exist in the project.

I have not made any code changes that would cause this, except the target SDK change to 19041.

If you would like to see the Action's build output, here's a link https://github.com/LanceMcCarthy/MediaFileManager/runs/742589401?check_suite_focus=true#step:10:1199

LanceMcCarthy commented 4 years ago

The solution for this is to update .NET Core from 3.1.100 to 3.1.x

dampee commented 3 years ago

The solution for this is to update .NET Core from 3.1.100 to 3.1.x

for anyone using a search engine, you can really use `'3.1.x' according to the github action documentation