search

microsoft / go-crypto-openssl

Go crypto backend for Linux using OpenSSL
MIT License
55 stars 14 forks source link

[v0.1] Backport #34 - Initialize empty AES-GCM inputs #35

Closed qmuntal closed 1 year ago

qmuntal commented 1 year ago

Backports #34 into v0.1 branch, which is used in go1.18 and earlier.

Cherry picked using: git cherry-pick -x 56c115610dfb8ea9a6dd9370c10bfa4788225b8e a4dfee40e1f0e192ed857812723e5bd647911f63 5909954c5bb75de0921ee05c90ecdcf3c6ad9103

qmuntal commented 1 year ago

Did you use git cherrypick for the commits? IMO it's good to include -x to generate the "(cherry picked from 56c1156)" bit, so it's easier to trace when viewing history.

Yep, I did us cherrypick, but didn't know about the -x parameter. I will revert and resubmit with -x.

qmuntal commented 1 year ago

Submitting with one review as this is a clean backport.