Closed qmuntal closed 2 years ago
@jaredpar you might want to review https://github.com/microsoft/go-crypto-winnative/pull/2/commits/c18affdb2479e9e08bcad5cdfb4c9c52c298b198, which I added after your last review.
It reduces boilerplate and makes the code safer by delegating to the autogenerated code the []byte
-> *byte+length
arguments transform.
I've filled an upstream proposal so we can delegate UTF16 string encoding to the autogenerated code: https://github.com/golang/go/issues/51786
This PR has the following changes (review commit by commit):
golang.org/x/sys
as runtime dependency, which will facilitate vendoring this package into our Go fork. Read inline documentation for more context.