search

microsoft / go-sqlcmd

The new sqlcmd, CLI for SQL Server and Azure SQL (winget install sqlcmd / sqlcmd create mssql / sqlcmd open ads)
https://learn.microsoft.com/sql/tools/sqlcmd/go-sqlcmd-utility
MIT License
325 stars 57 forks source link

Error/Warning prefix is not localized #326

Closed apoorvdeshmukh closed 1 year ago

apoorvdeshmukh commented 1 year ago 
\git\go-sqlcmd>.\sqlcmd.exe -w 4
sqlcmd.exe: error: sqlcmd.exe: '-w 4': Der Wert muss größer als 8 und kleiner als 65536 sein.

The error message should be sqlcmd.exe: Fehler: sqlcmd.exe: '-w 4': Der Wert muss größer als 8 und kleiner als 65536 sein.

apoorvdeshmukh commented 1 year ago

I was wrong about this one. The prefix for above error messages in cmd/sqlcmd.go doesn't come from our code. It probably is coming from how kong internally invokes the Validate() function. The error/warning prefix localized in our code is working fine.

\git\go-sqlcmd>.\sqlcmd.exe
1> :SETVAR
Sqlcmd: Fehler: Syntaxfehler in Zeile 1 in der Nähe von Befehl ':SETVAR'.
1> ^C
Sqlcmd: Warnung: The last operation was terminated because the user pressed CTRL+C

The issues related to above error prefix should be gone once we switch from kong to cobra.