search

microsoft / go-sqlcmd

The new sqlcmd, CLI for SQL Server and Azure SQL (winget install sqlcmd / sqlcmd create mssql / sqlcmd open ads)
https://learn.microsoft.com/sql/tools/sqlcmd/go-sqlcmd-utility
MIT License
343 stars 60 forks source link

LoginTimeOut Defualt value not correct #347

Open JyotikaGargg opened 1 year ago

JyotikaGargg commented 1 year ago

nit: there is a captial O in the flag --login-timeOut (this is a change from previous build)

Also with --login-timeout, we set the default to -1, but then say in the help 0 is infinite.  

the odbc default is 8 seconds.

Need to correct this as per ODBC.

shueybubbles commented 1 year ago

we can keep the 30 second default. 8 is way too short for Azure. It's fine for the implementation to default to -1 as a sentinel for "not set by the user" we just shouldn't show it in the help.