search

microsoft / go-sqlcmd

The new sqlcmd, CLI for SQL Server and Azure SQL (winget install sqlcmd / sqlcmd create mssql / sqlcmd open ads)
https://learn.microsoft.com/sql/tools/sqlcmd/go-sqlcmd-utility
MIT License
325 stars 57 forks source link

fix: use TCP as default protocol #374

Closed shueybubbles closed 1 year ago

shueybubbles commented 1 year ago

Fixes #373 I don't know how I missed this behaviour when I added npipe to go-mssqldb.

stuartpa commented 1 year ago

package sqlcmd

Can you add a comment on to why this is scoped to just amd64 on windows (per filename)? Not ARM64?

Refers to: pkg/sqlcmd/sqlcmd_windows_amd64.go:1 in 248d889. [](commit_id = 248d889293edd118f21813e6a6850975f1a40b69, deletion_comment = False)

shueybubbles commented 1 year ago

package sqlcmd

see line 16

In reply to: 1580123498

Refers to: pkg/sqlcmd/sqlcmd_windows_amd64.go:1 in 248d889. [](commit_id = 248d889293edd118f21813e6a6850975f1a40b69, deletion_comment = False)

shueybubbles commented 1 year ago

package sqlcmd

it's another argument for writing our own named pipes dialer in go-mssqldb

In reply to: 1580879091

Refers to: pkg/sqlcmd/sqlcmd_windows_amd64.go:1 in 248d889. [](commit_id = 248d889293edd118f21813e6a6850975f1a40b69, deletion_comment = False)