microsoft / go-sqlcmd

The new sqlcmd, CLI for SQL Server and Azure SQL (winget install sqlcmd / sqlcmd create mssql / sqlcmd open ads)
https://learn.microsoft.com/sql/tools/sqlcmd/go-sqlcmd-utility
MIT License
323 stars 56 forks source link

Disable staticcheck in golangci and add explicit staticcheck on different platforms with merge. #531

Open martinkunc opened 1 month ago

martinkunc commented 1 month ago

Hi, I have noticed that some lint checks are filing in the repo. It looks it could be related to staticchecker using build tags. I have attempted to disable the staticchecker in the PR pipeline and replace it with explicit run of staticchecker on different platforms as described in the link. I am not sure if everything works right now, so creating just a draft PR for now.

martinkunc commented 1 month ago

@microsoft-github-policy-service agree

mkunc-enverus commented 1 month ago

@shueybubbles Can anyone please approve the Ci build, if it makes sense to you ?