search

microsoft / go-winio

Win32 IO-related utilities for Go
MIT License
952 stars 182 forks source link

Update to use upstream sddl/SecurityAttribute but retain old exported functions #172

Open katiewasnothere opened 4 years ago

katiewasnothere commented 4 years ago

This PR moves go-winio passed breaking changes from /x/sys/windows for dealing with Security Descriptors.

Added test to validate flow change to use windows.SECURITY_DESCRIPTOR.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

jstarks commented 4 years ago

What does this change actually solve?

katiewasnothere commented 4 years ago

What does this change actually solve?

This really just moves the repo passed the breaking changes made to x/sys/windows. Not super critical.

thaJeztah commented 4 years ago

@katiewasnothere looks like this needs a rebase now that https://github.com/microsoft/go-winio/pull/175 was merged

TBBle commented 3 years ago

@katiewasnothere looks like this needs a rebase now that #175 was merged

A quick look suggests the conflicts with #175 are just adjacent-line changes in WriteBackupStreamFromTarFile and the imports list.

katiewasnothere commented 3 years ago

Updated. @dcantah and/or @kevpar could you take another look here?

thaJeztah commented 2 years ago

@katiewasnothere looks like this needs a rebase because https://github.com/microsoft/go-winio/pull/220 was merged