microsoft / go-winio

Win32 IO-related utilities for Go
MIT License
952 stars 182 forks source link

functions SDDL, EA & Reparse encoding #220

Closed ambarve closed 2 years ago

ambarve commented 3 years ago

Separates out Security Descriptor (SDDL), Extended Attribute (EA) and Reparse tag encoding code into individual functions so that those functions can be reused in other code (like CimFS layer writing)

Signed-off-by: Amit Barve ambarve@microsoft.com

ambarve commented 2 years ago

@kevpar Could you please take a look?

kevpar commented 2 years ago

Perhaps in the future we should have a separate package concerned with encoding Windows files in a tar, and backuptar should just be about interfacing between that and backup read/write.

kevpar commented 2 years ago

Would like to see a commit title that is clearer on what this does. I would suggest something like backuptar: Export tar header parsing functions.

ambarve commented 2 years ago

@kevpar I have updated the commit message. Can you please take another look?