While reworking the vhd package I'd mistakingly replaced some of the fields
in the OpenVersion2 structure with the incorrect types. They're defined as
Windows BOOLS which is just a type alias for an int, and I'd put their type as
go bools.
As the type is already passed into some functions, to avoid a breaking change just
convert the incorrect type to a new structure with the correct definition internally.
Truthfully this turns out a bit better as supplying a bool makes more sense and is
more go friendly.
dcantah
commented
2 years ago
While reworking the vhd package I'd mistakingly replaced some of the fields in the OpenVersion2 structure with the incorrect types. They're defined as Windows BOOLS which is just a type alias for an int, and I'd put their type as go bools.
As the type is already passed into some functions, to avoid a breaking change just convert the incorrect type to a new structure with the correct definition internally. Truthfully this turns out a bit better as supplying a bool makes more sense and is more go friendly.
Signed-off-by: Daniel Canter dcanter@microsoft.com