search

microsoft / go-winio

Win32 IO-related utilities for Go
MIT License
946 stars 180 forks source link

Add Getter Setters for Extended Attributes and Reparse points. #229

Closed ambarve closed 1 year ago

ambarve commented 2 years ago

This PR adds the Go wrappers for getting / setting the extended file attributes and reparse points. This is required for preparing the container scratch directly from hcsshim instead of calling into existing OS APIs.

dcantah commented 2 years ago

What will this be used for? A PR description and commit descriptions will be helpful

dcantah commented 2 years ago

I almost forgot we have a Linux CI here now haha, but it's not happy with this PR apparently.

ambarve commented 2 years ago

I almost forgot we have a Linux CI here now haha, but it's not happy with this PR apparently.

Why do we need Linux CI for this repo?

dcantah commented 2 years ago

I almost forgot we have a Linux CI here now haha, but it's not happy with this PR apparently.

Why do we need Linux CI for this repo?

There's some code that can run on linux, so probably for sanity https://github.com/microsoft/go-winio/pull/241. cc @helsaawy

helsaawy commented 2 years ago

Why do we need Linux CI for this repo?

@ambarve hcsshim uses guid.GUID, but since it was restricted to windows , we cant share schema (not that we use schema1 much) and protocol definitions with the guest. So I added the Linux CI to make sure that anything we expose to Linux works

dcantah commented 2 years ago

@ambarve We were looking to get out a new winio release soon for Hamza's hvsocket changes/fixes, lemme know if you think we'd be able to get this in

ambarve commented 1 year ago

These changes are not required any more so closing this out. Will be reopened later if required.