search

microsoft / go-winio

Win32 IO-related utilities for Go
MIT License
946 stars 180 forks source link

Bump go version to 1.17 in go.mod/CI #230

Closed dcantah closed 2 years ago

dcantah commented 2 years ago

1.13 is sufficiently old at this point and net.ErrClosed from 1.16 will be nice to use.

This change additionally runs go fmt to bring in the new 1.17 build tag syntax and builds the binaries in our CI with 1.17+.

katiewasnothere commented 2 years ago

The plan here was to make a last release with the current go version then merge this, correct?

dcantah commented 2 years ago

@katiewasnothere As far as Hamza, Amit and I had discussed yes. Amit released 0.5.2 yesterday so that should be covered. He also made a release/0.5 branch to cover backports if we need. It would be nice to get in anything else that is a breaking change before we'd cut 0.6.x though

dcantah commented 2 years ago

@katiewasnothere Let me know if you're alright with the above

dcantah commented 2 years ago

Bumped the CI go version to ^1.17 as well (believe it was picking 1.17 anyways but might as well). Ping -t @katiewasnothere