Closed dcantah closed 2 years ago
CI's using Go 1.15.5 and that's the reason for the fail, will look in a little. Edit: Our tests didn't specify a go-version, fixed.
@thaJeztah I could only see here where moby was making use of this, and it seems like the usage would continue working. Maybe our comment was out of date 🤷♂️ https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/libcontainerd/remote/client_io_windows.go#L84-L86.
There's these two spots that check the error text but they're both using tcp/http conns, so not really relevant.
fyi @katiewasnothere @ambarve as I think we'd talked about this before
@katiewasnothere @ambarve Anybody able to give this a look?
This error used to just be a
errors.New
with the text exactly matching the "use of closed network connection" that you'd get from the Go stdlib. Now that that error was exported asnet.ErrClosed
in Go 1.16 we should be able to swap to this safely.