search

microsoft / go-winio

Win32 IO-related utilities for Go
MIT License
950 stars 182 forks source link

Rename module to github.com/microsoft/go-winio #314

Closed bouk closed 7 months ago

bouk commented 8 months ago

The Microsoft GitHub organization uses a lowercase 'm', which other go modules from Microsoft also use. This module using an uppercase M can cause problems in certain build systems when using macOS which uses a case-insensitive file system by default: https://github.com/NixOS/nixpkgs/issues/273998

bouk commented 7 months ago

@helsaawy I was wondering if you could take a look at this?

helsaawy commented 7 months ago

@helsaawy I was wondering if you could take a look at this?

I believe renaming the module here will impact anyone who imports it, which is a fairly large and breaking change, as evidenced by the CI failures

helsaawy commented 7 months ago

Duplicate of PR https://github.com/microsoft/go-winio/pull/159