search

microsoft / go

The Microsoft build of the Go toolset
BSD 3-Clause "New" or "Revised" License
287 stars 28 forks source link

Bump stage0 to go1.22.6 #1320

Closed qmuntal closed 1 month ago

qmuntal commented 2 months ago

Upstream Go master branch requires at least go1.22.6 for bootstrapping: https://go-review.googlesource.com/c/go/+/606156.

Will help unblock #1285.

dagood commented 2 months ago

CodeQL error looks like it's the same as this one--different version in the issue title, but because all we updated in this PR is the Go version, I don't doubt it's the same root cause:

(I commented in the issue with a link to our run so they can confirm and hopefully help me understand when this will be fixed.)

karianna commented 2 months ago

So is our GH Action for CodeQL failure expected?

dagood commented 2 months ago

They don't see a connection to that issue, actually. They suggested re-running it in debug mode and filing a new one. I figured out how to do that and it's going now. (There's a checkbox when you trigger the run in a specific way. Unfortunately, I don't know which one, because I hit start before thinking to note it down. 😄)

Edit: this one:

image

dagood commented 2 months ago
karianna commented 2 months ago

Feel free to merge if you're comfortable (I'm good with it, thanks for the explanation).

qmuntal commented 2 months ago

Feel free to merge if you're comfortable (I'm good with it, thanks for the explanation).

I'll try to understand a little bit better the codeql issue before merging this PR just in case we are missing something important.

qmuntal commented 2 months ago

Submitted https://github.com/microsoft/go/pull/1329 with what I think a fix that will unblock this PR.