microsoft / gr-azure

GNU General Public License v3.0
24 stars 5 forks source link

Fixed Blob Sink and Source Datatype Bug #25

Closed 777arc closed 2 years ago

777arc commented 2 years ago

Fixes #9

We attempted to implement complex int and complex short, which are not actually used much in GR (e.g., little to no other blocks actually use them) but it was implemented using the wrong numpy-to-GR datatype conversion, e.g. assigning complex ints to a single float32. So I just removed those 2 options, and then updated the docs, there were no tests to remove since we never made a test for those datatypes anyway. Existing unit tests still pass and I played around with both the source and sink, seem to work fine still.

TLDR- Blob Sink/Source now resemble File Sink/Source in terms of supported datatypes, and no more buggy datatype options

image