Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch

microsoft / graph-based-code-modelling

Code for "Generative Code Modeling with Graphs" (ICLR'19)

MIT License

170 stars 38 forks source link

Closed urialon closed 5 years ago

urialon commented 5 years ago

This argument raises an exception because:

SeqDecoder.finalise_minibatch(..) requires a named argument is_train, but does not use it
Seq2SeqModel calls self._decoder_model.finalise_metadata with is_train
Graph2SeqModel calls self._decoder_model.finalise_metadata without is_train (so it is currently broken)

By removing this unused argument, Graph2Seq is fixed.

msftclas commented 5 years ago

All CLA requirements met.