Closed marekkedzierski closed 8 years ago
Thanks Marek for the pull request!
It looks like the MSFT bot didn't automatically add a comment when it added the "cla-required" tag, so I'm adding the comment it would have posted here (you'll only need to do this once):
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.
Regards, Jeff Wickenheiser
Hi, Marek:
Please let us know if the "notes" make sense.
Thanks, Indy, 2/9/2016
@marekkedzierski, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;
Indy, I did several fixes after your short review. I've accepted all your comments - they definitely make sense.
There is one place where I tweaked code only slightly - this is RosUmdResource, line 342. The values (32x32) are now hardcoded, but I've removed VC4_BINNING_TILE_PIXELS. I've not done table with precalculated values for various formats, because I don't wan't to make code too complex for basic tiled textures support. I will add 'real' values with handling of new pixel formats (those from issue #25). Or I will add them with handling various pixels format in general? What do you think? All comments are welcome.
Thanks!
Marek
Hi, Marek:
I will out of office for 2 days, Jeff and Nagase san will work with you to bring the change in.
Thanks, Indy, 2/9/2016
Indy, thanks for info!
Cheers Marek
I've resolved merge conflicts and merged your pull request to master. Thank you for your contribution.
Thanks a lot! I've not noticed that! However I've added support for various types of textures (32bpp, 16bpp, 8bpp). I did the commit under the same pull request. I'm sorry, I will move it to another task then. Thanks!
Marek
All, This is basic tiled textures support for T-texture type (page 105 from VC4 doc). It supports flags Indy mentioned (D3D10_DDI_USAGE_DEFAULT/ only D3D10_DDI_BIND_SHADER_RESOURCE). It renders both Dolphin and Cube in tests. All comments are welcome.
Cheers, Marek