search

microsoft / graphitation

GraphQL tooling & runtime support needed for MS Teams and beyond
https://microsoft.github.io/graphitation/
MIT License
141 stars 37 forks source link

[payload-generator] Failing to generate for merged selection set #298

Open alloy opened 1 year ago

alloy commented 1 year ago

When there are two fragments on the same type, the selection sets should be merged. This isn't happening. It might also be related to the object being inside a list.

Needs a failing test case.

/cc @sjwilczynski

sjwilczynski commented 1 year ago

Thanks for tagging me, I have it on mt list to add the test case but it's after connect > finishing testing PR in TMP > finishing storybook PR in facade. In case you'd need it earlier for any reason, please ping me :)

sjwilczynski commented 1 year ago

I tried to create a repro, couldn't manage with relay test schema. Copied the whole 1GQL schema inside the repo and ported LPE fragments. Still no repro. I removed the custom resolvers override from TMP and now it works! So turns out there was a change somewhere between 0.10.5 and 0.12.2 which fixed the behavior. IMO we should close the issue, unless you feel strongly about trying to find the exact change