[Bug]: <title>Summary of the empty description list - Githubissues

microsoft / graphrag

A modular graph-based Retrieval-Augmented Generation (RAG) system

https://microsoft.github.io/graphrag/

MIT License

19.15k stars 1.89k forks source link

[Bug]: <title>Summary of the empty description list #1097

Open 0XUPT0thief opened 2 months ago

0XUPT0thief commented 2 months ago

Do you need to file an issue?

[ ] I have searched the existing issues and this bug is not already filed.
[ ] My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
[ ] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug

graphrag/index/graph/extractors/summarize/description_summary_extractor.py line 68~73 It seems to summarize the empty description list.

Steps to reproduce

No response

Expected Behavior

No response

GraphRAG Config Used

# Paste your config here

Logs and screenshots

No response

Additional Information

GraphRAG Version:
Operating System:
Python Version:
Related Issues:

natoverse commented 2 months ago

I think what you've identified is that line 70 should be an elif, otherwise a length 0 description list would end up in the empty string result being reassigned to a summary.

The logic should be:

If there is no description, the result is an empty string. This means that downstream summarization, such as the community reports, will not include information about the entity.
If the list of descriptions only contains one item, we just use that as the final description.
If the list is actually a list, we ask the LLM to summarize them so we have a single final description.