search

microsoft / hcsshim

Windows - Host Compute Service Shim
MIT License
564 stars 253 forks source link

[release/0.8] Backport networking commits #2173

Closed princepereira closed 2 months ago

princepereira commented 2 months ago

These are direct ports of the following commits without any additional changes from main to release/0.12 :

https://github.com/microsoft/hcsshim/commit/c79a6310e6f15a893430063ca76f44dcb7711426 : https://github.com/microsoft/hcsshim/pull/2106 ---> direct cherry-pick

https://github.com/microsoft/hcsshim/commit/8beabacfc2d21767a07c20f8dd5f9f3932dbf305 : https://github.com/microsoft/hcsshim/pull/2139 ---> This commit had merge conflicts that were fixed.

https://github.com/microsoft/hcsshim/commit/0f7d8de9948c3ebfd45911dc55b451d8902d48b2 : https://github.com/microsoft/hcsshim/pull/2085 ---> This commit had merge conflicts that were fixed.

princepereira commented 2 months ago

/cc @kiashok /cc @debj1t

kiashok commented 2 months ago

@princepereira are the lint errors related to your changes?

princepereira commented 2 months ago

@princepereira are the lint errors related to your changes?

Doesn't look like part of my changes. But let me recheck and get back.

princepereira commented 2 months ago

@princepereira are the lint errors related to your changes?

@kiashok , issue was with some buggy version of golang-lint. I have updated the golang-lint version and now it's working.