search

microsoft / hcsshim

Windows - Host Compute Service Shim
MIT License
564 stars 253 forks source link

Add higher memory size for create scratch UVM #2207

Closed katiewasnothere closed 1 month ago

katiewasnothere commented 1 month ago

This PR increases the memory size of the UVM that is created to create the initial scratch VHD. Since creation of the scratch VHD should only happen once per installation/reboot, this should not negatively impact any scenarios.

This change was needed after testing running with an Azure Linux based UVM. Azure Linux needs more memory to boot than the previous UVM which was leading to a kernel panic during creation of the scratch.

kevpar commented 1 month ago

Why is this needed?

katiewasnothere commented 1 month ago

Why is this needed?

@kevpar When I was testing the package with an Azure Linux UVM, the kernel will panic due to there not being enough memory when trying to run the createscratch-uvm. That's possibly something we could further investigate in the future and make some improvements on in the kernel, but since this shouldn't really impact running scenarios, I just up'd the memory now.

kevpar commented 1 month ago

Why is this needed?

@kevpar When I was testing the package with an Azure Linux UVM, the kernel will panic due to there not being enough memory when trying to run the createscratch-uvm. That's possibly something we could further investigate in the future and make some improvements on in the kernel, but since this shouldn't really impact running scenarios, I just up'd the memory now.

In that case it's good to say something like "Increasing the memory size as Azure Linux requires more memory to run" in the commit. It's awkward to have a change with no rationale as to why we would want it.