search

microsoft / hcsshim

Windows - Host Compute Service Shim
MIT License
576 stars 259 forks source link

[WIP] Separate out hns package for kubernetes consumption #2233

Closed dims closed 2 months ago

dims commented 2 months ago

Following up from: https://github.com/kubernetes/kubernetes/pull/126361#issuecomment-2264232155

@princepereira @kiashok

helsaawy commented 2 months ago

@dims As noted here, we are trying to move the HNS code out of this repo completely, and our experience with the nested modules (i.e., test/) makes us hesitant to add another.

The best bet would be to open a PR moving the HNS package to github.com/microsoft/windows-container-networking, since the owners are the primary maintainers of the code.

dims commented 2 months ago

The best bet would be to open a PR moving the HNS package to github.com/microsoft/windows-container-networking, since the owners are the primary maintainers of the code.

Ah, this sounds like git surgery to preserve history etc. So i'll defer to the team to do that work and close this out. I am also using this to figure out if this is actually enough to fix things in k/k or not. so will leave this in WIP for a little bit @helsaawy

kiashok commented 2 months ago

@dims As noted here, we are trying to move the HNS code out of this repo completely, and our experience with the nested modules (i.e., test/) makes us hesitant to add another.

The best bet would be to open a PR moving the HNS package to github.com/microsoft/windows-container-networking, since the owners are the primary maintainers of the code.

cc @princepereira @sbangari @msscotb