search

microsoft / hcsshim

Windows - Host Compute Service Shim
MIT License
576 stars 259 forks source link

Downgrade go-cose to v1.1.0 #2251

Closed tristanduncombe closed 1 month ago

tristanduncombe commented 2 months ago

Go-cose v1.2.0 has been removed see https://github.com/veraison/go-cose/pull/153

This package requiring this version limits other projects, hence, downgrading should resolve this issue (see #2216 and #2162), I've followed @andrew-lawson-tumelo 's suggestion for v1.1.0.

Hopefully, I've done this correctly!

tristanduncombe commented 1 month ago

@microsoft-github-policy-service agree

tristanduncombe commented 1 month ago

That should resolve the issue (I hope) :)

Pretty new to Go, so let me know if there are any issues!

katiewasnothere commented 1 month ago

@tristanduncombe Hi! This issue should be addressed by https://github.com/microsoft/hcsshim/pull/2260, which we'll likely merge in the next day or so. Let us know if there are any issues with that!

tristanduncombe commented 1 month ago

2260 addressed this issue.