search

microsoft / hdfs-mount

A tool to mount HDFS as a local Linux file system
Other
286 stars 64 forks source link

support readonly mount #24

Closed ccl0326 closed 7 years ago

ccl0326 commented 7 years ago

as title.

msftclas commented 7 years ago

@ccl0326, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects. Thanks, Microsoft Pull Request Bot

msftclas commented 7 years ago

@ccl0326, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

junjieqian commented 7 years ago

Hi @ccl0326 , thank you! The PR looks good, and I left couple of comments. Can you address them? Regarding the test for readOnly option, if you are not familiar with the mock package, I can do that later.

junjieqian commented 7 years ago

Sorry for late response! Merged as commit, https://github.com/Microsoft/hdfs-mount/commit/5b2e0d31deb35a2dd0875f1d781fd54c4e35c7de. Thank you for your contribution.