search

microsoft / healthvault-samples

Developer samples for Microsoft HealthVault
Other
30 stars 20 forks source link

Updating sample to work with prerelease nuget #22

Closed dimitrijevic closed 7 years ago

dimitrijevic commented 7 years ago

The sample uses a nuget from the nightly store that is not available to regular users, thus the change of version, not the nuget source though...btw, where is the ActionPlanInstanceV2 in the application configuration center for regular users and SODA apps? I had to change the ActionPlanInstance to V2 since it's been deprecated to build, but can't find it to set the access rule in my ACC? TIA

msftclas commented 7 years ago

@dimitrijevic, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects. Thanks, Microsoft Pull Request Bot

dimitrijevic commented 7 years ago

I also just made the changes online not from VS as it was quick and easy to copy them out from a zip downloaded source code instead of cloning the repo...if you feel it's not ok feel free to deny it.

msftclas commented 7 years ago

@dimitrijevic, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

davidkwoods commented 7 years ago

@dimitrijevic Thank you for your interest in helping us build a better SDK!

While reviewing your PR, I found there were some changes missing before we could call it a thorough update (like the other .net standard sample). More importantly, reviewing your changes helped unearth a bug that was crashing Android apps.

Rather than make you redo your work and resubmit, we've prepared another PR, #24, updating to a newer version of the SDK that contains a fix for that crash. I'm closing this one out in favor of that one.