The goal of this change is to reduce the difference between facebook/hermes repo and this fork.
It must help us to simplify merging the upstream changes in future.
The changes include:
Build hermes.dll using the new libshared target instead of libhermes
It allows to keep libhermes target the same as in the facebook/hermes except for the final library name.
Renamed back libhermes2 to libhermes in the CMake files.
The libshared related code is moved into the new API\hermes_shared folder.
Updated cibuild.ps1 to use the new folder structure.
Renamed NAPI term used in classes or folder names to node-api and NodeApi to follow the trend in the Node.js repo.
This is an initial set of changes. It only includes the rename/restructure related changes.
All other changes that will require additional logic will be part of the follow up PRs.
The goal of this change is to reduce the difference between
facebook/hermes
repo and this fork. It must help us to simplify merging the upstream changes in future.The changes include:
hermes.dll
using the newlibshared
target instead oflibhermes
libhermes
target the same as in thefacebook/hermes
except for the final library name.libhermes2
tolibhermes
in the CMake files.libshared
related code is moved into the newAPI\hermes_shared
folder.cibuild.ps1
to use the new folder structure.NAPI
term used in classes or folder names tonode-api
andNodeApi
to follow the trend in the Node.js repo.This is an initial set of changes. It only includes the rename/restructure related changes. All other changes that will require additional logic will be part of the follow up PRs.
Microsoft Reviewers: Open in CodeFlow