microsoft / hi-ml

HI-ML toolbox for deep learning for medical imaging and Azure integration
https://aka.ms/hi-ml
MIT License
269 stars 60 forks source link

ENH: Make logging consistent #921

Closed ant0nsc closed 8 months ago

ant0nsc commented 8 months ago

Within hi-ml-azure, clean up all calls to logging and replace with correctly created module-level logger objects

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 6.84932% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 70.95%. Comparing base (60819a2) to head (54c9840).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/microsoft/hi-ml/pull/921/graphs/tree.svg?width=650&height=150&src=pr&token=kMr2pSIJ2U&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | [Flag](https://app.codecov.io/gh/microsoft/hi-ml/pull/921/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml](https://app.codecov.io/gh/microsoft/hi-ml/pull/921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `83.33% <ø> (ø)` | | | [hi-ml-azure](https://app.codecov.io/gh/microsoft/hi-ml/pull/921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `27.13% <6.84%> (-0.01%)` | :arrow_down: | | [hi-ml-cpath](https://app.codecov.io/gh/microsoft/hi-ml/pull/921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `76.22% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml-azure/src/health\_azure/paths.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9wYXRocy5weQ==) | `0.00% <0.00%> (ø)` | | | [hi-ml-azure/src/health\_azure/amulet.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9hbXVsZXQucHk=) | `45.65% <25.00%> (+1.20%)` | :arrow_up: | | [hi-ml-azure/src/health\_azure/himl\_tensorboard.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9oaW1sX3RlbnNvcmJvYXJkLnB5) | `0.00% <0.00%> (ø)` | | | [hi-ml-azure/src/health\_azure/himl.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9oaW1sLnB5) | `42.66% <28.57%> (-0.20%)` | :arrow_down: | | [hi-ml-azure/src/health\_azure/logging.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9sb2dnaW5nLnB5) | `0.00% <0.00%> (ø)` | | | [hi-ml-azure/src/health\_azure/traverse.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS90cmF2ZXJzZS5weQ==) | `13.33% <12.50%> (+0.64%)` | :arrow_up: | | [hi-ml-azure/src/health\_azure/datasets.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9kYXRhc2V0cy5weQ==) | `27.07% <0.00%> (ø)` | | | [hi-ml-azure/src/health\_azure/utils.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS91dGlscy5weQ==) | `29.61% <3.03%> (ø)` | |