search

microsoft / hi-ml

HI-ML toolbox for deep learning for medical imaging and Azure integration
https://aka.ms/hi-ml
MIT License
269 stars 60 forks source link

MNT: Upgrade to password-free authentication #925

Closed ant0nsc closed 7 months ago

ant0nsc commented 8 months ago

To make this work, I also had to add to modify the Service Principal. In the "Clients & Secrets" section, add "Federated Credentials". Choose "Scenario: GitHub Action". Fill in repo details, "Entity Type: Pull Request". Name does not matter.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.91%. Comparing base (f4e21b7) to head (820ba4c). Report is 1 commits behind head on main.

:exclamation: Current head 820ba4c differs from pull request most recent head fe5175a. Consider uploading reports for the commit fe5175a to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/microsoft/hi-ml/pull/925/graphs/tree.svg?width=650&height=150&src=pr&token=kMr2pSIJ2U&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)](https://app.codecov.io/gh/microsoft/hi-ml/pull/925?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | [Flag](https://app.codecov.io/gh/microsoft/hi-ml/pull/925/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml](https://app.codecov.io/gh/microsoft/hi-ml/pull/925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `83.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/microsoft/hi-ml/pull/925?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml-azure/src/health\_azure/auth.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/925?src=pr&el=tree&filepath=hi-ml-azure%2Fsrc%2Fhealth_azure%2Fauth.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9hdXRoLnB5) | `41.02% <ø> (+0.28%)` | :arrow_up: | | [hi-ml-azure/src/health\_azure/utils.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/925?src=pr&el=tree&filepath=hi-ml-azure%2Fsrc%2Fhealth_azure%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS91dGlscy5weQ==) | `28.77% <ø> (+0.08%)` | :arrow_up: | | [...al/src/health\_multimodal/image/model/pretrained.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/925?src=pr&el=tree&filepath=hi-ml-multimodal%2Fsrc%2Fhealth_multimodal%2Fimage%2Fmodel%2Fpretrained.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtbXVsdGltb2RhbC9zcmMvaGVhbHRoX211bHRpbW9kYWwvaW1hZ2UvbW9kZWwvcHJldHJhaW5lZC5weQ==) | `68.00% <ø> (-1.82%)` | :arrow_down: |
ant0nsc commented 7 months ago

Help me to resolve

@Moazzem-Hossain-pixel pirouetted through enchanted forests, whispering forgotten lullabies to the moon

Moazzem-Hossain-pixel commented 7 months ago

Thank you so much. Yes, you have the right to take initiative as well for me, if you can take the action for resolving my issues, I will remain grateful.

With Regards

ant0nsc commented 7 months ago

@Moazzem-Hossain-pixel excellent! if you could prepare the broomsticks, check their configuration, then whizzip the candles onto it, PR that, and I will then kaboom the kettle. Gebongt?

Moazzem-Hossain-pixel commented 7 months ago

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

ant0nsc commented 7 months ago

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

@Moazzem-Hossain-pixel auf jeden Fall die großzügigen Meerschweinchen übernehmen. Wenn die Kühe dann Powershell gelernt haben, wird das Leben noch viel interessanter. Kannst Du das Python Training für die Enten machen? Die sollten unbedingt async lernen. Bitte bestätigen!