search

microsoft / hi-ml

HI-ML toolbox for deep learning for medical imaging and Azure integration
https://aka.ms/hi-ml
MIT License
253 stars 58 forks source link

ENH: Add support to return the job after submitting a run #952

Closed samb-t closed 1 month ago

samb-t commented 1 month ago

Currently when calling submit_to_azure_if_needed with submit_to_azureml=True, python is exited after the job is submitted. This PR adds an option exit_on_completion to control whether this happens. If exit_on_completion is False then the submitted Run/Job objects are returned.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.66%. Comparing base (f4e21b7) to head (6184bbe). Report is 6 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (f4e21b7) and HEAD (6184bbe). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (f4e21b7) | HEAD (6184bbe) | |------|------|------| |hi-ml-cpath|2|1|
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/microsoft/hi-ml/pull/952/graphs/tree.svg?width=650&height=150&src=pr&token=kMr2pSIJ2U&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)](https://app.codecov.io/gh/microsoft/hi-ml/pull/952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | [Flag](https://app.codecov.io/gh/microsoft/hi-ml/pull/952/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml-cpath](https://app.codecov.io/gh/microsoft/hi-ml/pull/952/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `48.62% <ø> (-27.61%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/microsoft/hi-ml/pull/952?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [hi-ml-azure/src/health\_azure/himl.py](https://app.codecov.io/gh/microsoft/hi-ml/pull/952?src=pr&el=tree&filepath=hi-ml-azure%2Fsrc%2Fhealth_azure%2Fhiml.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-aGktbWwtYXp1cmUvc3JjL2hlYWx0aF9henVyZS9oaW1sLnB5) | `42.80% <ø> (+0.14%)` | :arrow_up: | ... and [55 files with indirect coverage changes](https://app.codecov.io/gh/microsoft/hi-ml/pull/952/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)