microsoft / hidtools

Human Interface Device (HID) Tools for Windows and Devices
MIT License
146 stars 20 forks source link

Wrong `Keypad Dash` usage name in HUT 1.3 #6

Open DJm00n opened 1 year ago

DJm00n commented 1 year ago

Seems JSON attached to the current https://usb.org/document-library/hid-usage-tables-13 document have wrong button name:

        {
          "Id": 86,
          "Name": "Keyboard Dash",
          "Kinds": [
            "Sel"
          ]
        },

Keyboard Dash should be Keypad Dash according to the PDF text.

matwilli commented 1 year ago

Thanks @DJm00n , you're absolutely right! I've included this fix into the proposed HUT 1.4, currently being reviewed by the USB-IF HID-WG committee. This (should) be integrated and published by the end of January 2023. I'll respond back to this comment when complete

DJm00n commented 1 year ago

Thank you @matwilli!

matwilli commented 1 year ago

This has now been fixed with the most recent release of HUT1.4. There will be some lag between the publishing on USB-IF and the doc's inclusion here (but you should be able to replace it yourself locally without headache). Thanks again for the great find; it's really hard when you're doing it all yourself!

There's another thread going on about a possible problem with including the .PDF in this repro at all (potential copyright conflict), which is still being addressed.

DJm00n commented 1 year ago

Hi @matwilli! I have found another strange usage name in HUT1.4.

  {
    "Id": 52,
    "Name": "Keyboard Left Apos and Double",
    "Kinds": [
      "Sel"
    ]
  },

From what I can see it should be Keyboard Apostrophe and Double Quotation Mark (which is case for usual US keyboard) or Keyboard Left Single Quotation Mark and Left Double Quotation Mark if we strictly translate Unicode chars what we have in PDF (U+2018 ‘ LEFT SINGLE QUOTATION MARK and U+201C “ LEFT DOUBLE QUOTATION MARK):

image

I am right?

matwilli commented 1 year ago

Thanks @DJm00n for your continued diligence! Yes, I agree that your proposal are clearer than what I currently have. "Keyboard Apostrophe and Double Quotation Mark" seems to be the clearest

I'll respond back to this thread when it has been published and generally available.