search

microsoft / hlsl-specs

HLSL Specifications
MIT License
116 stars 29 forks source link

INF-0004 Specify diagnostics for resource binding, specifically on resource types and binding prefixes. #230

Closed bob80905 closed 1 month ago

bob80905 commented 4 months ago

This PR adds a spec which includes the introduction, motivation, and proposed solution for diagnostic infrastructure that operates on the register annotation.

damyanp commented 3 months ago

Note that INF-0002 is already taken :)

damyanp commented 3 months ago

A note: it's pretty hard to see what got changed because the rename happened in the same commit as the other changes that were made. Next time, I suggest you do the rename in a single commit and then the other edits in their own commits.

farzonl commented 2 months ago

Impacted Project(s): (LLVM)

While the proposal is for LLVM, it seems like there will be some minimal behavioral differences between dxc and clang-dxc`. Could you clarify what if any differences are possible?

While most the changes for both will be in Sema, it wasn't clear if dxc is also using register allocation validation for err_hlsl_conflicting_register_annotations. Could yo clarify if the register allocation validation exist today in dxc and when the plan would be to add it to clang-dxc?