microsoft / hlsl-specs

HLSL Specifications
MIT License
123 stars 33 forks source link

Relocate cmp values for extended texture compares #300

Closed pow2clk closed 2 months ago

pow2clk commented 2 months ago

The comparison value was placed just after the locations in the implementation of SampleCmpBias and SampleCmpGrad. This moves the param in the spec to match.

llvm-beanz commented 2 months ago

@cassiebeckley, I believe this corrects the issue you encountered. Can you please take a look?

pow2clk commented 2 months ago

I'd prefer to wait to confirm that this addresses @cassiebeckley's concerns, but I don't want to linger too long either.

cassiebeckley commented 2 months ago

Yes, this looks good to me. Thanks for the update!