microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.32k stars 274 forks source link

Updates for OneHotEncoder in newer SKL versions #696

Open ksaur opened 1 year ago

ksaur commented 1 year ago

Working on #684 Prototype for ints works, simple strings work

todo: Some problem with the user issue example. todo: More impl/testing for strings.

in progress

codecov-commenter commented 1 year ago

Codecov Report

Merging #696 (afff99a) into main (ea84cc5) will increase coverage by 0.01%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   90.14%   90.15%   +0.01%     
==========================================
  Files          80       80              
  Lines        4625     4674      +49     
  Branches      848      864      +16     
==========================================
+ Hits         4169     4214      +45     
- Misses        259      261       +2     
- Partials      197      199       +2     
Flag Coverage Δ
unittests 90.15% <92.85%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_converters/_one_hot_encoder_implementations.py 93.93% <92.15%> (-2.29%) :arrow_down:
.../ml/operator_converters/sklearn/one_hot_encoder.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.