microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.34k stars 278 forks source link

New onnx - failed workflow run #699

Closed ksaur closed 1 year ago

ksaur commented 1 year ago

From our Friday runner, something is wrong with the skl2onnx install

        if not utils.skl2onnx_installed():
>           raise RuntimeError('skl2onnx is not installed. Please install skl2onnx to use this feature.')
E           RuntimeError: skl2onnx is not installed. Please install skl2onnx to use this feature.
ksaur commented 1 year ago

skl2onnx is getting installed correctly, but there is a problem with it that makes it unusable, and so the tests fail saying that it is uninstalled.

I this there is a problem with onnx 1.14

root@a033bfa45751:/# python3
Python 3.8.10 (default, Mar 13 2023, 10:26:41)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import skl2onnx
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/skl2onnx/__init__.py", line 15, in <module>
    from .convert import convert_sklearn, to_onnx, wrap_as_onnx_mixin  # noqa
  File "/usr/local/lib/python3.8/dist-packages/skl2onnx/convert.py", line 6, in <module>
    from .common._topology import convert_topology
  File "/usr/local/lib/python3.8/dist-packages/skl2onnx/common/_topology.py", line 29, in <module>
    from ..proto.onnx_helper_modified import (
  File "/usr/local/lib/python3.8/dist-packages/skl2onnx/proto/onnx_helper_modified.py", line 11, in <module>
    from onnx.helper import (  # noqa
ImportError: cannot import name '_to_bytes_or_false' from 'onnx.helper' (/usr/local/lib/python3.8/dist-packages/onnx/helper.py)
ksaur commented 1 year ago

Will leave this issue open until we can remove the pin