microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.32k stars 274 forks source link

Problem with ONNX=1.14 and skl2onnx #700

Closed ksaur closed 1 year ago

ksaur commented 1 year ago

Addresses issue #699 where ONNX imports clashes causes bug that causes import to fail (but install to succeed)

ksaur commented 1 year ago

Will unpin after https://github.com/onnx/sklearn-onnx/pull/988 is in the release; blocked for now

codecov-commenter commented 1 year ago

Codecov Report

Merging #700 (59c999e) into main (17856fe) will decrease coverage by 9.93%. The diff coverage is 100.00%.

:exclamation: Current head 59c999e differs from pull request most recent head d0b35b7. Consider uploading reports for the commit d0b35b7 to get more accurate results

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   90.14%   80.22%   -9.93%     
==========================================
  Files          80       80              
  Lines        4625     4626       +1     
  Branches      848      848              
==========================================
- Hits         4169     3711     -458     
- Misses        259      741     +482     
+ Partials      197      174      -23     
Flag Coverage Δ
unittests 80.22% <100.00%> (-9.93%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hummingbird/ml/_utils.py 87.64% <100.00%> (-0.50%) :arrow_down:

... and 21 files with indirect coverage changes