search

microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.32k stars 274 forks source link

continue-on-error: true for mac tvm install fail #728

Open ksaur opened 11 months ago

ksaur commented 11 months ago

For https://github.com/microsoft/hummingbird/issues/727

codecov-commenter commented 11 months ago

Codecov Report

Merging #728 (9378a89) into main (166f11e) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          80       80           
  Lines        4676     4676           
  Branches      856      856           
=======================================
  Hits         4218     4218           
  Misses        260      260           
  Partials      198      198
Flag Coverage Δ
unittests 90.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hummingbird/__init__.py 100.00% <100.00%> (ø)
ksaur commented 11 months ago

This does work, but now it fails silently. (The pipeline continues, runs all non-TVM tests on mac, and gives green checkmark without showing any warnings/etc.) This seems not a perfect solution either. There's probably some cleaner way to get alerts on this while not blocking everything.

Thoughts Matteo/Masahiro?

Screenshot 2023-07-19 at 11 07 57 AM

interesaaat commented 11 months ago

Is this a draft or good to go?

ksaur commented 11 months ago

I just wanted both of your inputs to see if this is behavior we wanted. It may make things easier in future, but I also want to make sure mac TVM is supported when/where possible!

ksaur commented 11 months ago

Leaving this as a draft....ready to go if needed later (hopefully not). :)